Upgrade onig, to get it compiling with GCC 15 #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
414owen
added a commit
to 414owen/tokenizers
that referenced
this pull request
May 1, 2025
Now, you can build with: ``` --no-default-features --features=fancy-regex ``` Which previously didn't work. You had to enable the `unstable_wasm` flag. I think using `fancy_regex` without wasm is a valid use-case, as I've seen extremely slow build times using `onig`. See: huggingface#1730 Onig also breaks, sometimes, with compiler updates. See: huggingface#1771 Closes huggingface#1729
This was referenced May 1, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
Now, you can build with: ``` --no-default-features --features=fancy-regex ``` Which previously didn't work. You had to enable the `unstable_wasm` flag. I think using `fancy_regex` without wasm is a valid use-case, as I've seen extremely slow build times using `onig`. See: #1730 Onig also breaks, sometimes, with compiler updates. See: #1771 Closes #1729
McPatate
approved these changes
May 27, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Seems like there were new releases since this PR: https://github.com/rust-onig/rust-onig/releases So an update to onig 6.5 should fix this. |
|
@414owen if you can update it happy to merge |
Distributions are starting to ship with GCC 15, which won't build `onig`. We can upgrade `onig` to an unreleased version, which fixes the issue.
414owen
force-pushed
the
os/fix-onig-build-gcc-15
branch
from
a3ad375 to
91b2005
Compare
|
👍 PR updated |
|
Thanks @414owen 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributions are starting to ship with GCC 15, which won't build
onig. We can upgradeonigto an unreleased version, which fixes the issue. We should make a mental note to upgrade to a stable point release, when one is available (although at the moment, the onig repository is archived, so I'm not sure when that will happen).